Render links with compressed ids

[imtayadeway]

@miq-bot add-label api, enhancement
@miq-bot assign @abellotti

[abellotti]

should not have been changed, keeping inbound post as is.

[abellotti]

looks good, the one POST to change to same input, also where specs redefine compressed url's in the expectation, might be nice to declare those similarly to their uncompressed counterparts, i.e. vm1_url and vm1_compress_url.

[abellotti]

we also need the href_slugs compressed for consistency, I think both methods in lib/api/utils.rb need updating.

[imtayadeway]

@abellotti took care of those concerns, but I think the might be nice part I'll leave for a follow up? With a big change like this I think I prefer seeing what changed directly even if it makes things a bit more verbose

[abellotti]

Thanks @imtayadeway for the update. can I bother you for one additional test in spec/lib/api/utils_spec.rb so we test fetching with resource_search_by_href_slug with both id and compressed id ?

[miq-bot]

Checked commits imtayadeway/manageiq@4b46873~...195530a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
59 files checked, 2 offenses detected

app/controllers/api/base_controller/renderer.rb

• ❗ - Line 401, Col 39 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 49, Col 22 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

[abellotti]

Thanks @imtayadeway for updating this. 🎼

I'll go ahead and merge this.

Let's sync up you, myself and @jntullo once in the repo regarding the nice part. We can take a single spec example that uses both ways (let defined *_url for requests and generated compressed url for the responses) and find a consistent/elegant signature for both before we update them all. Thanks.