Make sure passed ids for habtm relation are unique #15651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @agrare |
|
Great commit messages though :D |
|
@agrare damned, yes. But the spec is great :-) Let me push the right first commit. :-) |
Test we take only unique ids for the HABTM relations, if not unique, the relation table could have duplicates or fail the unique constraint.
Make sure that passed ids for HABTM relation are uniq
Ladas
force-pushed
the
make_sure_passed_ids_for_habtm_relation_are_unique
branch
from
669c112 to
0a3faf3
Compare
|
@agrare @pkliczewski now it should be correct :-) @pkliczewski a side note: I was thinking about removing this branch entirely, since it's slower and we can't apply the batch saving. So the correct solution would be to model every N:M mapping table as a separate InventoryCollection, so getting rid of the HasAndBelongsToMany. So it will stay until we do this in all providers. :-) |
|
Checked commits Ladas/manageiq@e384bd6~...0a3faf3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure passed ids for habtm relation are unique, otherwise it could lead to duplication in the relation table or unique index constraint violation.
-- it's enhancement in a sense, that we don't need to filter the data in the parser