Fix bug in InventoryCollection#find_by with non-default ref #15648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small followup to #15447.
The
ref
was not being passed tofind()
, so the id was looked up in wrong hash, most likely resulting in nil.(
lazy_find_by(...)
with same params worked.)At this point, no code was affected (containers graph refresh is only use of secondary refs, but only used
lazy_find_by
; I stumbled on this when debugging interactively...).@miq-bot add-label bug
@agrare @Ladas Please review. (This could be a good time to ask me to add tests ;-))