Let ansible worker gracefully stop #15643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1474508 When the ansible worker is not responding, let it try to gracefuly exit by marking it as stopping. Allow, the stopping worker code to eventually kill the worker if it doesn't exit on it's own. While we're allowing the worker to gracefully exit, don't allow multiple ansible monitor workers to run at once. Normally, a replacement worker is started the moment we ask a prior worker to exit.
|
Checked commit jrafanie@bc8c26f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
approved these changes
Jul 24, 2017
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2017
Let ansible worker gracefully stop (cherry picked from commit 3eeabd5) https://bugzilla.redhat.com/show_bug.cgi?id=1474840
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…efully_stop Let ansible worker gracefully stop (cherry picked from commit 3eeabd5) https://bugzilla.redhat.com/show_bug.cgi?id=1474840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1474508
When the ansible worker is not responding, let it try to gracefuly exit
by marking it as stopping. Allow, the stopping worker code to eventually
kill the worker if it doesn't exit on it's own.
While we're allowing the worker to gracefully exit, don't allow multiple
ansible monitor workers to run at once. Normally, a replacement worker
is started the moment we ask a prior worker to exit.