Add a marker file for determining when the ansible setup has been run #15642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we have a definitive way to determine if we have successfully run the setup for embedded ansible on a particular server Before this change, the thread running the setup could be killed and when we tried to start the service again, we would see #configured? as true even if we didn't run through the whole playbook. Now, we will not write this marker file until we finish running the playbook so the next worker will know to attempt the setup if the previous one was killed. https://bugzilla.redhat.com/show_bug.cgi?id=1474427
carbonin
force-pushed
the
add_complete_marker_for_embedded_ansible_setup
branch
from
3043d41 to
cd863fd
Compare
|
Checked commit carbonin@cd863fd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 lib/embedded_ansible.rb
|
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2017
…ded_ansible_setup Add a marker file for determining when the ansible setup has been run (cherry picked from commit 9e0fe66) https://bugzilla.redhat.com/show_bug.cgi?id=1474835
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…or_embedded_ansible_setup Add a marker file for determining when the ansible setup has been run (cherry picked from commit 9e0fe66) https://bugzilla.redhat.com/show_bug.cgi?id=1474835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we have a definitive way to determine if we have successfully run the setup for embedded ansible on a particular server
Before this change, the thread running the setup could be killed and when we tried to start the service again, we would see #configured? as true even if we didn't run through the whole playbook.
Now, we will not write this marker file until we finish running the playbook so the next worker will know to attempt the setup if the previous one was killed.
https://bugzilla.redhat.com/show_bug.cgi?id=1474427