Adds virtual totals for servers, vms and hosts to Physical Infrastructure Providers #15613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
rodneyhbrown7
changed the title
|
@miq-bot remove_label wip |
miq-bot
changed the title
|
@miq-bot assign @blomquisg |
juliancheal
approved these changes
Jul 25, 2017
blomquisg
suggested changes
Jul 26, 2017
| physical_servers.inject(0) { |t, physical_server| physical_server.host.nil? ? t : t + 1 } | ||
| end | ||
|
|
||
| def total_hosts; count_physical_servers_with_host; end |
There was a problem hiding this comment.
This can just be a method alias, I think:
alias_method :total_hosts, :count_physical_servers_with_hostSame for total_vms.
There was a problem hiding this comment.
Implemented this as
alias :total_hosts :count_physical_servers_with_host
|
Checked commits https://github.com/lenovo/manageiq/compare/fbf4e2d0ff90608b06d2e52650f33c9caa071f50~...d78329b426690cca4ab126d5e60db5347eb9fb4e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data will enable additional detail in the UI and via the REST API for determining how many physical servers, hosts and virtual machines are being managed by a particular provider. The relationships between these resources is already maintained.
Overrides the total_hosts, total_vms attributes of ExtManagementSystem and adds the attribute total_physical_servers.
@miq-bot add_label enhancement, wip