Custom reconnect block #15605
Merged
Custom reconnect block #15605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom_reconnect_block to handle complex reconnect logic
Invoke custom_reconnect_block if defined as part of saving, allowing us to do reconnec instead of saving.
Test that reconnect logic works
Ladas
force-pushed
the
custom_reconnect_block
branch
from
13fd8e0 to
6f261c4
Compare
Fix rubocop issues
Ladas
force-pushed
the
custom_reconnect_block
branch
from
675af3f to
f805115
Compare
|
Checked commits Ladas/manageiq@9b04398~...f805115 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
reviewed
Jul 24, 2017
| @@ -67,6 +67,10 @@ def save!(inventory_collection, association) | |||
| end | |||
| end | |||
|
|
|||
| unless inventory_collection.custom_reconnect_block.nil? | |||
| inventory_collection.custom_reconnect_block.call(inventory_collection, inventory_objects_index, attributes_index) | |||
| end | |||
There was a problem hiding this comment.
So for objects that are re-connected by this block, what prevents them from being created by the next section?
There was a problem hiding this comment.
for now we need to remove them from inventory_objects_index, the rest will get created.
I think once we implement this for hosts and vms, we can generalize this alghorithm
agrare
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom reconnect block allowing us to implement a complex reconnect logic of records.