change ManageIQ::Environment to run bundle install on plugin_setup #15589
Conversation
* change plugin_setup task to run bundle install * add plugin_update task to run bundle update
lib/manageiq/environment.rb
Outdated
| @@ -19,6 +19,15 @@ def self.manageiq_plugin_setup | |||
| setup_test_environment(:task_prefix => 'app:', :root => plugin_root) | |||
| end | |||
|
|
|||
| def self.manageiq_plugin_update | |||
| # determine plugin root dir. Assume we are called from a 'bin/setup' script in the plugin root | |||
| plugin_root = Pathname.new(caller_locations.last.absolute_path).dirname.parent | |||
There was a problem hiding this comment.
way too magic IMHO., please pass a dir argument. bin/setup etc should be debuggable by everyone, focusing on commands that it actually runs, not ruby magic...
There was a problem hiding this comment.
agreed, I did it that way so that we dont have to change bin/setup in the provider repos.
I'll add a default arg though
|
Checked commits durandom/manageiq@81635a3~...4c87a46 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Overall makes sense, though I think we'd still want at least
https://docs.travis-ci.com/user/caching/#Determining-the-bundle-path has some (not very clear) explanations on BUNDLE_PATH - caching interaction. |
|
Note that we don't do update on Travis
Beni Cherniavsky-Paskin <[email protected]> schrieb am Di. 18. Juli
2017 um 14:32:
… Overall makes sense, though I think we'd still want at least --jobs=3 for
bin/update?
Some alternatives I tried that don't work well:
-
bundle update without --path: works but seems to break caching(?),
fetches all gems
https://travis-ci.org/cben/manageiq-providers-kubernetes/jobs/254778155
added a bundle show => gems got installed in e.g.
/home/travis/.rvm/gems/ruby-2.3.3/bundler/gems/manageiq-providers-openshift-f2105258d580
-
setting BUNDLE_PATH env var instead of --path => other commands like bin/rails
app:test:vmdb:setup don't find the gems :-( Perhaps if we set
BUNDLE_PATH in .travis.yml ?
https://docs.travis-ci.com/user/caching/#Determining-the-bundle-path has
some (not very clear) explanations on BUNDLE_PATH - caching interaction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJ4YBK39CZlnuK_EiC9ja7_rEJAGcF3ks5sPKW7gaJpZM4ObHed>
.
|
|
I know, I was thinking of also enabling |
| @@ -11,4 +11,4 @@ else | |||
| end | |||
|
|
|||
| require gem_root.join("spec/manageiq/lib/manageiq/environment").to_s | |||
| ManageIQ::Environment.manageiq_plugin_setup | |||
| ManageIQ::Environment.manageiq_plugin_setup(gem_root) | |||
There was a problem hiding this comment.
I think you meant for this to call manageiq_plugin_update?
|
Merging on red since the errors are unrelated. @durandom Since we are not using the bin/update script in Travis, I'm merging, but you may need to change for #15589 (comment) |
|
Confirmed, https://travis-ci.org/ManageIQ/manageiq-providers-openshift/jobs/254862190 passed bin/setup 🎉 (that PR is gonna fail tests, that's expected) |
continued from #15508 I think its worth to add an
manageiq_plugin_updatemethod, as it seems to be different to runbundle installvsbundle update.reverts parts of #15585
similar to the revert in #15588
@Fryguy @bdunne @cben