Don't run the broker for ems_inventory if update_driven_refresh is set

[agrare]

If using WaitForUpdates inventory collection then disable MiqEmsRefreshCoreWorker and don't run the MiqVimBrokerWorker for the ems_inventory role.

[Fryguy]

These failures in Travis look legit

[Fryguy]

A visually nicer pattern might be

    %w(
      ems_metrics_collector
      ems_operations
      smartproxy
      smartstate
    ).tap do |roles|
      roles << 'ems_inventory' unless Settings.prototype.ems_vmware.update_driven_refresh
    end

[agrare]

👍 will do

[agrare]

These failures in Travis look legit

Yeah that's because the setting doesn't exist until ManageIQ/manageiq-providers-vmware#76 adds it

[miq-bot]

Checked commits agrare/manageiq@153cf09~...94d85ed with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 5 offenses detected

app/models/miq_ems_refresh_core_worker.rb

• ❗ - Line 8, Col 12 - Style/PredicateName - Rename has_required_role? to required_role?.

app/models/miq_vim_broker_worker.rb

• ❗ - Line 4, Col 22 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 4, Col 31 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.

app/models/miq_vim_broker_worker/runner.rb

• ❗ - Line 119, Col 35 - Style/ZeroLengthPredicate - Use !empty? instead of length > 0.
• ❗ - Line 48, Col 7 - Style/PredicateName - Rename has_ems_inventory_role? to ems_inventory_role?.

[blomquisg]

I'm confused why you have to do this as well as check the setting and role in the has_ems_inventory_role? method in the runner.

[agrare]

The point of this is to control if the broker should start or not, the check in the runner is to control the cache_scope once it has started. Some examples would probably help.

Assuming you're using update_driven_refresh:

1. The only active role on this appliance is ems_inventory
   In this case the broker shouldn't even start, that's what the above block handles

2. There are e.g. ems_operations and ems_inventory roles active
   In this case we do want to start the broker to handle the ems_operations role but without checking the setting in the runner it would use cache_scope_ems_refresh which uses a lot more memory and defeat the purpose. This is what the check in the runner handles.

[blomquisg]

Thanks!