Use update:ui rake task, instead of update:bower #15578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea being that the UI should know what to update, not the backend.. Right now, as of ManageIQ/manageiq-ui-classic#1699, `update:ui` just runs `update:bower` and `update:yarn`. It will soon also run `webpack:compile`, and eventually drop `update:bower`, none of which should visible on the backend.
10 tasks
|
Checked commit https://github.com/himdel/manageiq/commit/170a23dbbdbc8b667c74bac1db0d08427e35b540 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Fryguy
reviewed
Jul 17, 2017
| @@ -37,7 +37,7 @@ def self.ensure_config_files | |||
| def self.while_updating_bower | |||
| # Run bower in a thread and continue to do the non-js stuff | |||
| puts "Updating bower assets in parallel..." | |||
There was a problem hiding this comment.
@himdel I already merged but maybe the comment should move into the update_ui method or perhaps in the update:ui rake task itself?
There was a problem hiding this comment.
Oh, you're right, thanks! :)
I'll do a second PR..
carbonin
added a commit
to carbonin/manageiq-pods
that referenced
this pull request
Jul 31, 2017
This mirrors the changes in ManageIQ/manageiq#15578
simaishi
added a commit
to simaishi/manageiq-appliance-build
that referenced
this pull request
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea being that the UI should know what to update, not the backend..
Right now, as of ManageIQ/manageiq-ui-classic#1699,
update:uijust runsupdate:bowerandupdate:yarn.It will soon also run
webpack:compile, and eventually dropupdate:bower, none of which should visible on the backend.This just updates all the mentions of
update:bowerwithupdate:uiin manageiq/.Similar PRs to appliance-build and manageiq-pods will follow.