Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Don't use parentheses around a method call." #15577

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 17, 2017

Confusion caused by not using parentheses around method params

bdunne added 2 commits July 17, 2017 11:19
Confusion caused by not using parentheses around method params
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2017

Checked commits bdunne/manageiq@dc03237~...8b5dbf4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@jrafanie jrafanie added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 17, 2017
@jrafanie jrafanie merged commit e1ad218 into ManageIQ:master Jul 17, 2017
@NickLaMuro
Copy link
Member

@bdunne uh.... why does this PR exist? Weren't these fixed in #15561 ?

@bdunne
Copy link
Member Author

bdunne commented Jul 17, 2017

@NickLaMuro I want #15561 to be strictly a rubocop -a PR. This is a different cop.

@bdunne bdunne deleted the fix_parens branch July 17, 2017 21:45
@NickLaMuro
Copy link
Member

Okay, I see, looks like you cherry picked this from #15561, which was not clear in this PR or that one. I understand now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants