Cast virtual attribute 'Hardware#ram_size_in_bytes' to bigint

[yrudman]

There is PG::NumericValueOutOfRange thrown in report on ram_size_in_bytes

https://bugzilla.redhat.com/show_bug.cgi?id=1464154

@miq-bot add-label bug, fine/yes

\cc @gtanzillo

[jrafanie]

Arel... 😱 .... @kbrock @NickLaMuro Can you review this? I have no idea.

@yrudman Can you add a test that recreates the problem? I don't understand how it overflows ram_size_in_bytes for a single vm in a report. I was under the impression it was a problem aggregating many hardwares for many vm/instances that caused the overflow.

[NickLaMuro]

This seems reasonable to me, as long as the casting is passed on in the multiplication (I think it is, but unsure). I agree with adding a test to confirm this functionality fails in the old code, and works with the new.

This may be my fault from some of the aggregation mixin performance improvements I did a while back, so if it was, I apologize.

[yrudman]

I was testing before/after manually.
Not sure how to write rspec, virtual_column_sql_value(Hardware, "ram_size_in_bytes") is working fine. Also, ActiveRecord::Base.connection.execute("SELECT hardwares.memory_mb * 1048576 FROM hardwares") failing on console :

but works fine from rspec

[NickLaMuro]

@yrudman I would say write a test that creates a hardware record with the same value as what you have in the screenshot you just share, and then try calling the ram_size_in_bytes method on that record before and after this change. Should break in master and then be fixed with your change.

So, you should just be able to use the console you have open already, and run ActiveRecord::Base.connection.select_values("SELECT MAX(hardwares.memory_mb) FROM hardwares") to get your out of range value to plug into a spec. The spec should be something simple like this:

describe "#ram_size_in_bytes" do
  it "should not cause out of range errors" do
    FactoryGirl.create(:hardware, :memory_mb => <<VALUE_YOU_GOT_FROM_THE_CONSOLE_ABOVE>>)
    expect{ Hardware.select(:ram_size_in_bytes).all }.to_not raise_error(ActiveRecord::StatementInvalid)
  end
end

[yrudman]

As an alternative solution I have migration PR (not merged) to change datatype of memory_mb to bigint and on my test db that column was bigint. So, I was struggling with providing test which is failing on master ....

[miq-bot]

Checked commits yrudman/manageiq@5231493~...068eb1b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

[gtanzillo]

Nice! 👍

[simaishi]

Fine backport details:

$ git log -1
commit fec5287534126e44555e4096997e0745e798b416
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Jul 13 09:27:04 2017 -0400

    Merge pull request #15554 from yrudman/cust-ram_size_in_bytes-to-bigint
    
    Cast virtual attribute 'Hardware#ram_size_in_bytes' to bigint
    (cherry picked from commit a1b007b9c76f62a5d152720039b782358fdd7629)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478565