Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path for including miq-syntax-checker #15551

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

skateman
Copy link
Member

If you navigate to Automate -> Customization, the console returns:

F, [2017-07-12T10:44:25.500141 #28075] FATAL -- :   
F, [2017-07-12T10:44:25.500221 #28075] FATAL -- : LoadError (cannot load such file -- miq-syntax-checker):
F, [2017-07-12T10:44:25.500279 #28075] FATAL -- :   
F, [2017-07-12T10:44:25.500352 #28075] FATAL -- : activesupport (5.0.4) lib/active_support/dependencies.rb:293:in `require'
activesupport (5.0.4) lib/active_support/dependencies.rb:293:in `block in require'
activesupport (5.0.4) lib/active_support/dependencies.rb:257:in `block in load_dependency'
activesupport (5.0.4) lib/active_support/dependencies.rb:662:in `new_constants_in'
activesupport (5.0.4) lib/active_support/dependencies.rb:257:in `load_dependency'
activesupport (5.0.4) lib/active_support/dependencies.rb:293:in `require'
app/models/miq_ae_method.rb:1:in `<top (required)>'

This was probably caused by ManageIQ/manageiq-gems-pending#237 and ManageIQ/manageiq-automation_engine#51. I'm not sure if this is The Right Way™ to fix it, but I needed a quick workaround.

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2017

Checked commit skateman@539e5cc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@cben
Copy link
Contributor

cben commented Jul 12, 2017

@Fryguy

@chessbyte chessbyte self-assigned this Jul 12, 2017
@chessbyte chessbyte merged commit 8eb967f into ManageIQ:master Jul 12, 2017
@chessbyte chessbyte added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 12, 2017
@jrafanie
Copy link
Member

Looks good to me. If there's a better fix, we can fix it later. Merging

@jrafanie
Copy link
Member

Wow, @chessbyte beat me ❤️

@skateman skateman deleted the fix-syntax-checker branch July 12, 2017 12:50
@Fryguy
Copy link
Member

Fryguy commented Jul 12, 2017

😢 I had that change locally and didn't save the file 😢 I'm amazed the tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants