Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MiqApache from manageiq-gems-pending #15548

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 11, 2017

MiqApache is only used by the "evmserver" parts of MiqServer, so it
should live here.

@carbonin Please review.

@Fryguy
Copy link
Member Author

Fryguy commented Jul 11, 2017

gems/pending removing in ManageIQ/manageiq-gems-pending#235

Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Did you want to do any of the cleanup bits that rubocop is suggesting or do you want to keep this PR a straight move?

@Fryguy
Copy link
Member Author

Fryguy commented Jul 11, 2017

keep this PR a straight move

MiqApache is only used by the "evmserver" parts of MiqServer, so it
should live here.
@Fryguy Fryguy force-pushed the move_miq_apache_from_gems_pending branch from 0a2cbb9 to deb6811 Compare July 11, 2017 21:20
@Fryguy
Copy link
Member Author

Fryguy commented Jul 11, 2017

Updated the brakeman.ignore

@miq-bot
Copy link
Member

miq-bot commented Jul 11, 2017

Checked commit Fryguy@deb6811 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 7 offenses detected

lib/miq_apache/config.rb

lib/miq_apache/control.rb

spec/lib/miq_apache/control_spec.rb

@carbonin carbonin self-assigned this Jul 11, 2017
@carbonin carbonin added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 11, 2017
@carbonin carbonin merged commit d89cd6e into ManageIQ:master Jul 11, 2017
@Fryguy Fryguy deleted the move_miq_apache_from_gems_pending branch July 25, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants