Give active queue worker time to complete message #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo we'll need a BZ for this... What do you think? I hate the evm:status change but if stopping is confusing to users, I'm not sure how else to clarify this without actually changing the stopping to some other value.... it's been stopping for so many years |
|
This pull request is not mergeable. Please rebase and repush. |
jrafanie
force-pushed
the
give_active_queue_worker_time_to_complete_message
branch
from
2b057ba to
71dc00e
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1481800 In e5f4bd3, we added a 10 minute timeout that would give workers a little time to complete their work after they exceed their memory threshold before we'd kill them. This causes workers to be killed prematurely before completing the work item. What we really want is for the work item to complete but kill the worker if the worker has exceeded memory/time thresholds and the work item hasn't completed in a reasonable time. This reasonable time is the msg_timeout associated with the queue message.
https://bugzilla.redhat.com/show_bug.cgi?id=1481800 The worker is probably working on a queue message that takes a long time so we let it try to complete this work item and have a follow up work item where we ask the worker to exit cleanly on it's own. "Stop pending" better describes this graceful worker exit workflow. ``` ** Using session_store: ActionDispatch::Session::MemCacheStore Checking EVM status... Zone | Server | Status | ID | PID | SPID | URL | Started On | Last Heartbeat | Master? | Active Roles ---------+--------+---------+---------------+-------+-------+-------------------------+----------------------+----------------------+---------+----------------------------------------------------------------------------------------------------------------------------------------------------- default | EVM | started | 1000000000001 | 38192 | 38206 | druby://127.0.0.1:50844 | 2017-07-07T21:29:20Z | 2017-07-07T21:32:34Z | true | automate:database_operations:database_owner:ems_inventory:ems_operations:event:reporting:scheduler:smartstate:user_interface:web_services:websocket Worker Type | Status | ID | PID | SPID | Server id | Queue Name / URL | Started On | Last Heartbeat | MB Usage ------------------+--------------+---------------+-------+-------+---------------+---------------------+----------------------+----------------------+---------- MiqGenericWorker | stop pending | 1000000000207 | 38374 | 38380 | 1000000000001 | generic | 2017-07-07T21:32:19Z | 2017-07-07T21:32:33Z | 245 MiqUiWorker | started | 1000000000206 | 38234 | | 1000000000001 | http://0.0.0.0:3000 | 2017-07-07T21:29:21Z | 2017-07-07T21:32:34Z | 533 ```
jrafanie
force-pushed
the
give_active_queue_worker_time_to_complete_message
branch
from
71dc00e to
8388fdf
Compare
jrafanie
changed the title
|
Checked commits jrafanie/manageiq@31c07a1~...8388fdf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gtanzillo this is ready to go and for backport to fine and darga... the original was backported to both, see: https://bugzilla.redhat.com/show_bug.cgi?id=1395736#c34 |
simaishi
pushed a commit
that referenced
this pull request
Aug 17, 2017
…_to_complete_message Give active queue worker time to complete message (cherry picked from commit 09d2aae) https://bugzilla.redhat.com/show_bug.cgi?id=1482670
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 17, 2017
…_to_complete_message Give active queue worker time to complete message (cherry picked from commit 09d2aae) https://bugzilla.redhat.com/show_bug.cgi?id=1482672
|
Euwe backport details: |
jrafanie
deleted the
give_active_queue_worker_time_to_complete_message
branch
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ker_time_to_complete_message Give active queue worker time to complete message (cherry picked from commit 09d2aae) https://bugzilla.redhat.com/show_bug.cgi?id=1482670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causes workers to be killed prematurely before completing the work item.
if the worker has exceeded memory/time thresholds and the work item hasn't
completed in a reasonable time. This reasonable time is the msg_timeout
associated with the queue message.
so we let it try to complete this work item and have a follow up work
item where we ask the worker to exit cleanly on it's own. "Stop pending"
better describes this graceful worker exit workflow.
https://bugzilla.redhat.com/show_bug.cgi?id=1481800