Add validate_blacklist method for VM pre-provisioning

[djberg96]

This modifies the MiqRequestWorkflow::DialogFieldValidation module by adding a validate_blacklist method that provisioning templates can then hook into.

Specifically, this is needed for Azure (though possibly other providers) which have special blacklists for VM usernames and passwords that would pass a regex check but are not considered valid by Microsoft. For example, you cannot use "abc@123" as a password for Azure VM's, even though that would normally pass a validity check.

These lists are too long to be put into a regex validation directly. It simply isn't practical, so I believe a separate method is necessary.

For more information please see https://docs.microsoft.com/en-us/azure/virtual-machines/windows/faq

Partially solves https://bugzilla.redhat.com/show_bug.cgi?id=1454829. The other half will happen on the Azure provider side.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq/commit/b9c9a7bdd8e2d8e7e8e1decfaba058cd88004b77 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

spec/models/miq_request_workflow_spec.rb

• ❗ - Line 362, Col 38 - Style/WordArray - Use %w or %W for an array of words.

[djberg96]

@gmcculloug @blomquisg @h-kataria Look ok?

[syncrou]

👍 LGTM

[gmcculloug]

Looks good.

The one thing I wanted to mention is that we should always make these types of validations optional so the user can modify the dialog to allow special characters since the dialog is just collecting the initial name to use and it can be modified before passing to the provider.

For example, adding the sequence $n{04} into the dialog name would cause the code to substitute an enumerated leading-zero value. The characters $ and {} may not be valid for a VM name but may mean something to the back-end code or could be substituted in custom automation code.

We are going with the 80/20 rule here as most users would not be entering special characters at dialog ordering time. The one exception would likely be an admin setting up a Catalog Item in which case they would have more knowledge of the back-end customizations.

[djberg96]

@miq-bot add_label fine/yes

[simaishi]

Fine backport details:

$ git log -1
commit 0c39c467217b47095ac4a8c8bd47fa87c02241a7
Author: Greg McCullough <[email protected]>
Date:   Mon Jul 10 15:55:19 2017 -0400

    Merge pull request #15513 from djberg96/validate_blacklist
    
    Add validate_blacklist method for VM pre-provisioning
    (cherry picked from commit 34cab60b852f37c0c5145a07b68cd07f45cc6e8c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478563