MulticastLogger#reopen shouldn't be used because it's backed by other loggers #15512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
approved these changes
Jul 5, 2017
|
@bdunne this looks better in principle, but perhaps raise |
imtayadeway
reviewed
Jul 5, 2017
lib/vmdb/loggers/multicast_logger.rb
Outdated
| @@ -23,6 +23,10 @@ def add(*args, &block) | |||
| true | |||
| end | |||
|
|
|||
| def reopen(_logdev) | |||
There was a problem hiding this comment.
You may want to _logdev = nil here since the argument is optional
bdunne
force-pushed
the
multicastlogger_reopen
branch
from
ce86ca7 to
ce62bcb
Compare
|
Checked commit bdunne@ce62bcb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
We use this extensively in our code where methods are defined but not implemented (in particular when we create abstract interfaces and this is the "default" base method), so for consistency, I think we can keep it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise NotImplementedError for now until we figure out if there is a use case for
#reopenand what that looks like.Based on discussions in #15510