-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct identifier for VM Retirement #15509
Merged
abellotti
merged 1 commit into
ManageIQ:master
from
jntullo:bz/wrong_retirement_product_feature
Jul 5, 2017
Merged
Use correct identifier for VM Retirement #15509
abellotti
merged 1 commit into
ManageIQ:master
from
jntullo:bz/wrong_retirement_product_feature
Jul 5, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM @jntullo, could you check out travis. Thanks!! /cc @imtayadeway I see some api logging failures, not sure if related to your PR. |
Checked commit jntullo@680c290 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Thanks @jntullo for fixing this. 😍 |
simaishi
pushed a commit
that referenced
this pull request
Jul 7, 2017
…ature Use correct identifier for VM Retirement (cherry picked from commit 30f51d5) https://bugzilla.redhat.com/show_bug.cgi?id=1468614
Euwe backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
…ature Use correct identifier for VM Retirement (cherry picked from commit 30f51d5) https://bugzilla.redhat.com/show_bug.cgi?id=1478508
Fine backport details:
|
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…oduct_feature Use correct identifier for VM Retirement (cherry picked from commit 30f51d5) https://bugzilla.redhat.com/show_bug.cgi?id=1478508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the vm "retire" action is using the product feature
vm_retire
which aligns to Set Retirement Date. The identifier that should be used isvm_retire_now
which is the correct product feature for immediately retiring a VM.The response for before the fix if the user does not have "Set Retirement Date" permissions but has "Retire Now" permissions:
Response after the fix is applied to use the correct product feature:
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1464093
@miq-bot add_label api, bug, euwe/yes, fine/yes
@miq-bot assign @abellotti
cc: @yrudman