Adapt manageiq to new managers #15506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolitayer
force-pushed
the
new_providers
branch
2 times, most recently
from
453f3e6 to
a40bbcc
Compare
9 tasks
|
This pull request is not mergeable. Please rebase and repush. |
moolitayer
force-pushed
the
new_providers
branch
from
a40bbcc to
a5a4728
Compare
cben
reviewed
Jul 24, 2017
config/permissions.tmpl.yml
Outdated
| @@ -37,9 +37,11 @@ | |||
| - ems-type:hawkular_datawarehouse | |||
| - ems-type:monitoring # removed in https://github.com/ManageIQ/manageiq/pull/15506 | |||
There was a problem hiding this comment.
should this line also be removed, to fulfill the prophecy?
moolitayer
force-pushed
the
new_providers
branch
from
a5a4728 to
ceb8905
Compare
|
Checked commit moolitayer@ceb8905 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Reopening to pick up changes from ManageIQ/manageiq-providers-openshift#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: [merged] #15354
Adding two new providers to permissions file and ems_spec, should be merged after: