Add a relationship between generic objects and services. #15490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Aug 1, 2017
app/models/service.rb
Outdated
| @@ -203,6 +204,10 @@ def orchestration_stacks | |||
| service_resources.where(:resource_type => 'OrchestrationStack').collect(&:resource) | |||
| end | |||
|
|
|||
| def generic_objects | |||
| service_resources.where(:resource_type => 'GenericObject').collect(&:resource) | |||
There was a problem hiding this comment.
Should this be further optimized? Will it be called frequently?
lfu
force-pushed
the
service_with_generic_object
branch
from
b03b921 to
3fc4088
Compare
|
Checked commit lfu@3fc4088 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
reviewed
Aug 3, 2017
| @@ -203,6 +204,10 @@ def orchestration_stacks | |||
| service_resources.where(:resource_type => 'OrchestrationStack').collect(&:resource) | |||
| end | |||
|
|
|||
| def generic_objects | |||
| service_resources.where(:resource_type => 'GenericObject').includes(:resource).collect(&:resource) | |||
There was a problem hiding this comment.
👍 A separate PR should be created to add .includes(:resource) to the orchestration_stacks methods above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a relationship between generic objects and services.
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, services