Return Not Found on Snapshots Delete actions #15489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
reviewed
Jun 30, 2017
spec/requests/api/snapshots_spec.rb
Outdated
| @@ -262,6 +279,29 @@ | |||
| expect(response.parsed_body).to include(expected) | |||
| expect(response).to have_http_status(:ok) | |||
| end | |||
|
|
|||
| it "raises a 404 with proper message if a resource isn't found" do | |||
| api_basic_authorize(action_identifier(:vms, :delete, :snapshots_subresource_actions, :delete)) | |||
There was a problem hiding this comment.
I think you want the :post action here, and :snaphots_subcollection_actions (looks like this might be wrong in some of the examples above)
|
Checked commit jntullo@3ec4914 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM @jntullo Thanks for fixing this. 😍 |
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
…e_snapshot Return Not Found on Snapshots Delete actions (cherry picked from commit 0a3088e) https://bugzilla.redhat.com/show_bug.cgi?id=1478506
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…se_delete_snapshot Return Not Found on Snapshots Delete actions (cherry picked from commit 0a3088e) https://bugzilla.redhat.com/show_bug.cgi?id=1478506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the resource search for a snapshot happens within the rescue block, which means any resource search errors will be returned as a
200with a"success":falserather than the expected400 Not Found. This PR moves the resource search out of the rescue block.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1466225
@miq-bot add_label api, bug, fine/yes
cc: @imtayadeway