Add Amazon report to standard set of reports #15445
Conversation
|
|
| :queue_timeout: | ||
| :summary: | ||
| :hide_detail_rows: false | ||
| miq_group_id: 10000000000002 |
There was a problem hiding this comment.
there is no need for specific miq_group_id neither user_id, everybody can see this report
(so these two lines can be removed)
| rpt_group: Custom | ||
| rpt_type: Custom | ||
| priority: 20 | ||
| db: VmCloud |
There was a problem hiding this comment.
as this model VmCloud is not defined in
https://github.com/ManageIQ/manageiq/blob/master/config/miq_expression.yml#L2
please add it to this yaml.
this is will ensure that we can create the report based on this model:
|
@miq-bot unassign @lpichler |
|
@lpichler unrecognized command 'unassign', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
chessbyte
changed the title
adding VmCloud to miq_expression.yml
|
Checked commits vestival/manageiq@79c6f6d~...f13185e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@lpichler thanks! I just changed what you suggested and submit the changes! :-) 👍 |
|
@gtanzillo ready to merge? 👍 |
| @@ -63,6 +63,7 @@ | |||
| - User | |||
| - VimPerformanceTrend | |||
| - Vm | |||
| - VmCloud | |||
There was a problem hiding this comment.
I think, to preserve 🔤 , this needs to go two lines below
| and: | ||
| - REGULAR EXPRESSION MATCHES: | ||
| field: VmCloud-vendor | ||
| value: "/amazon/i" |
There was a problem hiding this comment.
How important is case insensitivity here? Is there not a discreet list of possible values for vendor? The reason I ask is that REGULAR EXPRESSION MATCHES is inefficient in that it can only be evaluated in memory. Using an alternative operator (such as LIKE, which is case sensitive) can be evaluated in SQL
|
Note that (caused a ui-classic spec fail) |
During the CloudForms Hackathon we agreed to include some of the reports we usually deliver during POCs as part of the built in reports in the product. We will create separate PR for each of the reports
Steps for Testing/QA [Optional]