Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with special AR setters #15439

Merged

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Jun 23, 2017

Deal with special AR setters, using AR records and proper type casting to get the right values for the DB.

@Ladas
Copy link
Contributor Author

Ladas commented Jun 23, 2017

@miq-bot assign @agrare

@Ladas
Copy link
Contributor Author

Ladas commented Jun 23, 2017

@miq-bot add_label enhancement, wip

@miq-bot miq-bot changed the title WIP deal with special AR setters [WIP] WIP deal with special AR setters Jun 23, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 4, 2017

This pull request is not mergeable. Please rebase and repush.

Ladas added 2 commits July 13, 2017 16:30
Deal with special AR setters using AR records
Use a proper type casting for the DB, solution inspired by
ActiveRecord import gem.
@Ladas Ladas force-pushed the deal_with_special_ar_setters_for_batch_saving branch from 5435221 to 80bafbf Compare July 13, 2017 14:30
@Ladas Ladas changed the title [WIP] WIP deal with special AR setters WIP deal with special AR setters Jul 13, 2017
@Ladas Ladas changed the title WIP deal with special AR setters Deal with special AR setters Jul 13, 2017
@Ladas
Copy link
Contributor Author

Ladas commented Jul 13, 2017

@miq-bot remove_label wip

@miq-bot
Copy link
Member

miq-bot commented Jul 13, 2017

Checked commits Ladas/manageiq@723093c~...80bafbf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot miq-bot removed the wip label Jul 13, 2017
@agrare agrare merged commit 0f00914 into ManageIQ:master Jul 17, 2017
@agrare agrare added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants