Use proper multi select condition #15436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we are using this for loading from the db: "col1 IN [a,b] AND col2 IN [e,f]" which does give incorrect results since we need to load exact combination: "(col1, col2) IN [(a,e), (b,f), (b,e)] The exact combination is especially needed when we are determining if we should create/delete/update the records. Unifying the comparation and loading from the db to the correct multiselect query.
Fix custom_db_finder for hardwares and networks, the finder for networks was not defined and the query was built badly.
Use build_multi_selection_condition in sql helper
|
@miq-bot add_label enhancement |
|
Checked commits Ladas/manageiq@78558b3~...4a706ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manager_refresh/inventory_collection.rb
|
agrare
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are using this for loading from the db:
"col1 IN [a,b] AND col2 IN [e,f]"
which does give incorrect results since we need to load exact
combination:
"(col1, col2) IN [(a,e), (b,f), (b,e)]
The exact combination is especially needed when we are
determining if we should create/delete/update the records.
Unifying the compare and loading from the db to the correct
multiselect query. And using it on appropriate places.