-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional logging into the websocket proxy for easier debugging #15428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the callers to match the new method signature, please. |
skateman
force-pushed
the
websocket-logging
branch
from
June 26, 2017 09:34
3c6d15b
to
73163cd
Compare
Checked commit skateman@73163cd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 7, 2017
Add additional logging into the websocket proxy for easier debugging (cherry picked from commit f2d7380) https://bugzilla.redhat.com/show_bug.cgi?id=1468613
Euwe backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
Add additional logging into the websocket proxy for easier debugging (cherry picked from commit f2d7380) https://bugzilla.redhat.com/show_bug.cgi?id=1478436
Fine backport details:
|
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Add additional logging into the websocket proxy for easier debugging (cherry picked from commit f2d7380) https://bugzilla.redhat.com/show_bug.cgi?id=1478436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a VNC/SPICE console, there is no logging message if the remote endpoint is inaccessible. This should print the possible socket exceptions into the
websocket_log
and so QE would see if the issue is with their setup or in our code.https://bugzilla.redhat.com/show_bug.cgi?id=1464006