Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging into the websocket proxy for easier debugging #15428

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 22, 2017

When opening a VNC/SPICE console, there is no logging message if the remote endpoint is inaccessible. This should print the possible socket exceptions into the websocket_log and so QE would see if the issue is with their setup or in our code.

https://bugzilla.redhat.com/show_bug.cgi?id=1464006

@martinpovolny
Copy link
Member

Fix the callers to match the new method signature, please.

@skateman skateman force-pushed the websocket-logging branch from 3c6d15b to 73163cd Compare June 26, 2017 09:34
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2017

Checked commit skateman@73163cd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit f2d7380 into ManageIQ:master Jul 4, 2017
@martinpovolny martinpovolny added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 4, 2017
@skateman skateman deleted the websocket-logging branch July 7, 2017 08:49
simaishi pushed a commit that referenced this pull request Jul 7, 2017
Add additional logging into the websocket proxy for easier debugging
(cherry picked from commit f2d7380)

https://bugzilla.redhat.com/show_bug.cgi?id=1468613
@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2017

Euwe backport details:

$ git log -1
commit 7ab4ecd7324dc5f5d3f0c9ddf58eeed1625590de
Author: Martin Povolny <[email protected]>
Date:   Tue Jul 4 13:15:41 2017 +0200

    Merge pull request #15428 from skateman/websocket-logging
    
    Add additional logging into the websocket proxy for easier debugging
    (cherry picked from commit f2d73802fef77276405aa5eaa2acfd2df31fb230)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468613

simaishi pushed a commit that referenced this pull request Aug 4, 2017
Add additional logging into the websocket proxy for easier debugging
(cherry picked from commit f2d7380)

https://bugzilla.redhat.com/show_bug.cgi?id=1478436
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit f83f7cff7b712c19025bd1b030ebf05469b321a9
Author: Martin Povolny <[email protected]>
Date:   Tue Jul 4 13:15:41 2017 +0200

    Merge pull request #15428 from skateman/websocket-logging
    
    Add additional logging into the websocket proxy for easier debugging
    (cherry picked from commit f2d73802fef77276405aa5eaa2acfd2df31fb230)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478436

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
Add additional logging into the websocket proxy for easier debugging
(cherry picked from commit f2d7380)

https://bugzilla.redhat.com/show_bug.cgi?id=1478436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants