fix shared example path in provider generator spec_helper.rb template

[jameswnl]

The generated spec_helper would include from the wrong path and so providers would not find the existing shared examples (as in this PR

[Fryguy]

@durandom @bdunne Thoughts? See the rationale in ManageIQ/manageiq-providers-ansible_tower#6

[Fryguy]

I'm wondering if the plugins should add Rails.root.join("spec/support") as well as Engine.root.join("spec/support") .

[Fryguy]

Note that this removes Rails.root.join("spec/shared"), but what I'm questioning is if we need to include Rails.root.join("spec/support")

[durandom]

The rationale behind this is explained in the README.md
And also in this PR #11414

what I'm questioning is if we need to include Rails.root.join("spec/support")

spec/support from the core is already loaded via the spec_helper from the core.
But then @jameswnl is right, that spec/shared from the core is also loaded via the core spec_helper
But (again :sigh:) I think we should not do this, hence it's listed in the pluggable providers todo dont use spec_helper from core in the providers

So, long story short.
I'd keep this (require core spec/shared)
But also add that require spec/support from the plugin.
Can you also create a spec/support dir then, like here

[jameswnl]

I am all for that a plugin's shared examples/cassettes should stay in it's own repo and hence this PR and that and that (although I don't quite understand how/why it is at current state).

@durandom now what you suggested changes are done.

[durandom]

👍 from me

[durandom]

for consistency you could. but 🤷‍♂️

Dir[ManageIQ::Providers::<%= class_name %>::Engine.root.join("spec/support/**/*.rb")].each { |f| require f }

[jameswnl]

yes, consistency is good, done!

[miq-bot]

Checked commit jameswnl@f13f75f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[bdunne]

👍 LGTM