We always want to setup the sample manageiq test db #15407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManageIQ could have new columns added so we want to migrate/reset our sample manageiq app's test db when running bin/setup or bin/update. For a mostly unrelated PR [1] that was open for a while, another PR [2] with a dependent migration on manageiq were both merged causing my development branch for [1] to fail because I had already setup the initial test database and bin/setup and bin/update were not migrating the test database to include the newly added column. [1] ManageIQ/manageiq-providers-amazon#256 [2] ManageIQ/manageiq-providers-amazon#259
|
Checked commit jrafanie@de9fbf7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ could have new columns added so we want to migrate/reset our
sample manageiq app's test db when running bin/setup or bin/update.
For a mostly unrelated PR [1] that was open for a while, another PR [2]
with a dependent migration on manageiq were both merged causing my
development branch for [1] to fail because I had already setup the
initial test database and bin/setup and bin/update were not migrating
the test database to include the newly added column.
[1] ManageIQ/manageiq-providers-amazon#256
[2] ManageIQ/manageiq-providers-amazon#259