Make sure that :host_target_vmware factory creates vmware hosts

[isimluk]

So, we get closer to the real life.

Then, fix specs expectations to match the real life.

@durandom , (side note) this fixes specs for #15195)

[miq-bot]

Checked commit isimluk@7e843de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[durandom]

👍 Although I'd rather move to testing the baseclasses. Would it be possible to make metric_spec work with a Host ?

cc @agrare

[isimluk]

Would it be possible to make metric_spec work with a Host ?

Too much work. Perhaps we can move these vmware specific tests to vmware provider.

From my past QA background, I actually like having tests closer to what the real-life input/outputs looks like. I mean, having tests data closer to what is actually run in reality yielded more real bugs found in my past life.

[durandom]

From my past QA background, I actually like having tests closer to what the real-life input/outputs looks like. I mean, having tests data closer to what is actually run in reality yielded more real bugs found in my past life.

Absolutely, but then in the vmware repo, as you said :)
So, cool for this.

@miq-bot assign @agrare