Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit capture threshold for container #15311

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Add explicit capture threshold for container #15311

merged 1 commit into from
Jun 28, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 6, 2017 •
edited
Loading

Description

The default capture_threshold value for the OpenShift object types container, container_group and node is 10 minutes (since these object types don't have their own capture_threshold definition in advanced settings). To maintain this rate of ems_metrics_collector message processing requires a large number of C&U Data Collector worker processes, which results in scaling several CFME appliances just to manage OpenShift Metrics.

This PR update the capture_threshold to 50 minutes.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1457765

@yaacov
Copy link
Member Author

yaacov commented Jun 6, 2017

@miq-bot add_label bug

@simon3z @cben @moolitayer @zeari please review

@miq-bot miq-bot added the bug label Jun 6, 2017
@yaacov
Copy link
Member Author

yaacov commented Jun 6, 2017

@miq-bot add_label providers/containers

@yaacov yaacov force-pushed the explicit-capture_threshold-for-container branch from a847637 to 1abf18c Compare June 6, 2017 13:19
@miq-bot
Copy link
Member

miq-bot commented Jun 6, 2017

Checked commit yaacov@1abf18c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@simon3z
Copy link
Contributor

simon3z commented Jun 6, 2017

@yaacov do you think you can try to run with this for a while to verify that rollups are happening consistently?

@yaacov
Copy link
Member Author

yaacov commented Jun 6, 2017

@yaacov do you think you can try to run with this for a while to verify that rollups are happening consistently?

np :-)

@yaacov
Copy link
Member Author

yaacov commented Jun 7, 2017

@yaacov do you think you can try to run with this for a while to verify that rollups are happening consistently?

Tested on my evm and providers, works fine 🎉

@simon3z ready for review / merge

@yaacov
Copy link
Member Author

yaacov commented Jun 8, 2017

@simon3z can we merge this ?

@yaacov
Copy link
Member Author

yaacov commented Jun 11, 2017

@miq-bot add_label fine/yes

@simon3z @blomquisg please review

https://bugzilla.redhat.com/show_bug.cgi?id=1457765 target 5.8.2

@yaacov
Copy link
Member Author

yaacov commented Jun 20, 2017

@simon3z @blomquisg ping ^^

@simon3z
Copy link
Contributor

simon3z commented Jun 20, 2017

LGTM 👍
@miq-bot assign blomquisg

@miq-bot miq-bot assigned blomquisg and unassigned simon3z Jun 20, 2017
@yaacov
Copy link
Member Author

yaacov commented Jun 26, 2017

@blomquisg ping ^^

@blomquisg blomquisg merged commit 7a43f09 into ManageIQ:master Jun 28, 2017
@blomquisg blomquisg added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 28, 2017
@blomquisg
Copy link
Member

@Fryguy thoughts on extracting these types of settings to the individual providers?

@Fryguy
Copy link
Member

Fryguy commented Jul 3, 2017

I'm hoping they go away or change dramatically in the rearchitecture, so let's pass on it.

simaishi pushed a commit that referenced this pull request Aug 4, 2017
@blomquisg @simaishi
Merge pull request #15311 from yaacov/explicit-capture_threshold-for-…
033cce4 
…container

Add explicit capture threshold for container
(cherry picked from commit 7a43f09)

https://bugzilla.redhat.com/show_bug.cgi?id=1478428
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit 033cce4de60911ec486109abc6b5526efde029bf
Author: Greg Blomquist <[email protected]>
Date:   Wed Jun 28 15:18:35 2017 -0400

    Merge pull request #15311 from yaacov/explicit-capture_threshold-for-container
    
    Add explicit capture threshold for container
    (cherry picked from commit 7a43f0939568e61b22db22ea41de26c4189095bb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478428

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
@blomquisg @d-m-u
Merge pull request ManageIQ#15311 from yaacov/explicit-capture_thresh…
b2e42e0 
…old-for-container

Add explicit capture threshold for container
(cherry picked from commit 7a43f09)

https://bugzilla.redhat.com/show_bug.cgi?id=1478428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon3z simon3z simon3z approved these changes

Assignees

@blomquisg blomquisg

Labels
bug fine/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yaacov @miq-bot @simon3z @blomquisg @Fryguy @simaishi