Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some minor typos from #15020 #15302

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Fix some minor typos from #15020 #15302

merged 1 commit into from
Jun 5, 2017

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jun 5, 2017

[skip ci]

@jrafanie jrafanie requested a review from NickLaMuro June 5, 2017 19:54
NickLaMuro
NickLaMuro approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@NickLaMuro NickLaMuro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... looks fine... but why didn't you just have me make these changes myself before you #yoloMerge'd it 5 min ago?

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2017

Checked commit jrafanie@263ac2b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@jrafanie
Copy link
Member Author

jrafanie commented Jun 5, 2017

So... looks fine... but why didn't you just have me make these changes myself before you #yoloMerge'd it 5 min ago?

@NickLaMuro the PR was already old and didn't want to be annoying ;-)

@NickLaMuro
Copy link
Member

@NickLaMuro the PR was already old and didn't want to be annoying ;-)

@jrafanie Well, frankly, I find "Fixed small typos" commits in the codebase more annoying (long term) then being asked fix them in a PR. ¯\_(ツ)_/¯

@bdunne bdunne merged commit fc1b237 into ManageIQ:master Jun 5, 2017
@bdunne bdunne added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 5, 2017
@bdunne bdunne self-assigned this Jun 5, 2017
@jrafanie jrafanie deleted the fix_typos branch June 6, 2017 01:57
@jrafanie
Copy link
Member Author

jrafanie commented Jun 6, 2017

lol @NickLaMuro #yoloMerge'd

I hate when I am about to click the green button to merge and I see a silly typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLaMuro NickLaMuro NickLaMuro approved these changes

Assignees

@bdunne bdunne

Labels
cleanup documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrafanie @miq-bot @NickLaMuro @bdunne