Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Check for timed out active tasks #15277

Merged
merged 6 commits into from
Jun 5, 2017

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Jun 1, 2017

Issue:
If reporting worker killed (kill -9 ) when report is still running than task status stays Running forever.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1457979

merged PR on master: #15231

@miq-bot add-label bug, core

@simaishi simaishi requested a review from jrafanie June 1, 2017 19:18
@simaishi simaishi self-assigned this Jun 1, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 1, 2017

Travis is currently failing for Euwe branch for a different reason - I will restart the job once that's fixed.

@yrudman yrudman force-pushed the merge-to-euwe-timing-out-tasks branch from 9ae347e to 25e08ca Compare June 1, 2017 19:34
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

@yrudman please address Travis failure. The other issue is now fixed and what's failing now seems to be related to this PR.

@yrudman yrudman force-pushed the merge-to-euwe-timing-out-tasks branch from 25e08ca to 9c3c082 Compare June 2, 2017 16:56
@yrudman yrudman force-pushed the merge-to-euwe-timing-out-tasks branch from 9c3c082 to c054235 Compare June 2, 2017 17:35
@miq-bot
Copy link
Member

miq-bot commented Jun 2, 2017

Checked commits yrudman/manageiq@320c640~...c054235 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 0 offenses detected
Everything looks fine. 🍰

@yrudman
Copy link
Contributor Author

yrudman commented Jun 2, 2017

@simaishi rspec for this PR fixed.
Travis failing on failing spec/models/manageiq/providers/google/cloud_manager/refresher_spec.rb:20 # ManageIQ::Providers::Google::CloudManager::Refresher

@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

@yrudman thanks - looking into that Google error which started happening in the last few hours, but that's not related to your PR, so that's ok for now. Will run the job again once that's fixed.

@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

@jrafanie Travis is good now - please review.

@jrafanie
Copy link
Member

jrafanie commented Jun 5, 2017

@jrafanie Travis is good now - please review.

@simaishi Looks great. I reviewed it with Yuri. Please merge when you're ready.

@simaishi simaishi merged commit ddeeecf into ManageIQ:euwe Jun 5, 2017
@simaishi simaishi added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 5, 2017
@yrudman yrudman deleted the merge-to-euwe-timing-out-tasks branch January 11, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants