set_miq_server Action #15262
Merged
set_miq_server Action #15262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellotti
reviewed
May 31, 2017
| vm.miq_server = miq_server | ||
| action_result(true, "Set miq_server id:#{miq_server.id} for #{vm_ident(vm)}") | ||
| rescue => err | ||
| action_result(false, "Cannot set miq_server - #{err}") |
There was a problem hiding this comment.
minor, "Failed to set miq_server - #{err}" to be consistent with others.
|
Checked commit jntullo@4dd9b01 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @jntullo for the enhancement, this LGTM!! 😍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
set_miq_serveraction to the API on both a VM resource and the VM collection for bulk setting of miq_servers.This is needed for PV ticket https://www.pivotaltracker.com/n/projects/1613907/stories/146327113
@miq-bot add_label enhancement, api, fine/no
@miq-bot assign @abellotti
cc: @h-kataria