Delete complement strategy for deleting top level entities using batches #15229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as WIP because this PR depends on #15227 |
chessbyte
changed the title
Allow all_manager_uuids to be serialized/deserialized
Adding :all_manager_uuids for complement deletion, used in batched targeted strategies.
Implement delete_complement method
Expose noop? method on InventoryCollection, being able to quickly check if the IC processing can be skipped. #Please enter the commit message for your changes. Lines starting
Check for noop before starting any work in IC. Helps to lower down the number of unnecessary queries.
Turn all foreign_keys to symbols, for consistent comparing.
Store skeletal_manager_uuids to optimize the where queries
Remove a wrong IC reference because it's self
Always return data with symbolized keys
Ladas
force-pushed
the
delete_complement_strategy_for_deleting_top_level_entities_using_batches
branch
from
a41d95a to
be3ddac
Compare
Ladas
changed the title
|
@miq-bot remove_label wip |
Remove to_s since we want to compare symbols
|
Checked commits Ladas/manageiq@c8904ae~...f822325 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manager_refresh/save_collection/saver/base.rb
|
|
@miq-bot add_label enhancement |
agrare
reviewed
May 30, 2017
| @@ -155,12 +155,13 @@ def add_remaining_inventory_collections(defaults, options = {}) | |||
|
|
|||
| def to_raw_data | |||
| collections_data = collections.map do |key, collection| | |||
| next if collection.data.blank? | |||
| next if collection.data.blank? && collection.manager_uuids.blank? && collection.all_manager_uuids.nil? | |||
There was a problem hiding this comment.
Why .blank? for manager_uuids but .nil? for all_manager_uuids?? They both look like arrays...
There was a problem hiding this comment.
collection.all_manager_uuids = [] will delete everything and nil is ignored
collection.manager_uuids [] or nil is equivalent, it should be marking that the collection will not be saving any data.
agrare
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
:delete_complement strategy for deleting top level entities using batch saving