Make request APIs consistent by restricting access to automation/provision requests to admin/requester #15186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
force-pushed
the
api/fix/request-access-consistency
branch
from
2e6efdb to
618a550
Compare
|
Checked commits imtayadeway/manageiq@1ae66cc~...618a550 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
abellotti
reviewed
May 26, 2017
| @@ -41,5 +41,16 @@ def deny_resource(type, id, data) | |||
| rescue => err | |||
| action_result(false, err.to_s) | |||
| end | |||
|
|
|||
| def find_automation_requests(id) | |||
There was a problem hiding this comment.
seem similar to the find_provision_requests, anyway we can have common code ?
There was a problem hiding this comment.
It might be good to do this as a follow up since there might be more opportunities to do this outside the scope of fixing these two endpoints
abellotti
reviewed
May 26, 2017
| klass.find_by!(:requester => User.current_user, :id => id) | ||
| end | ||
|
|
||
| def automation_requests_search_conditions |
There was a problem hiding this comment.
Same as above - this issue is broader than this PR, so might be best done in a follow up
|
@imtayadeway bump |
|
@abellotti bump |
|
LGTM 🎹 @imtayadeway please have a follow up PR to eliminate the common code (find_*_requests). Thanks. |
imtayadeway
added a commit
to imtayadeway/manageiq
that referenced
this pull request
Jul 5, 2017
Caused by collision of ManageIQ#15430 and ManageIQ#15186
Merged
imtayadeway
added a commit
to imtayadeway/manageiq-providers-amazon
that referenced
this pull request
Jul 5, 2017
These were broken by the introduction of ManageIQ/manageiq#15430 and ManageIQ/manageiq#15186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings consistency to the automation/provision requests API so that it filters/restricts access to requests in the same way as the generic requests API
@miq-bot add-label bug, api
@miq-bot assign @abellotti