Add constraint to vendor in Physical Server #15128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the value of vendor restricted to VENDOR_TYPES values to avoid nil references.
|
Checked commit https://github.com/lenovo/manageiq/commit/2e209e032d59b333d74d7e4d27c91210611706c6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @juliancheal |
|
LGTM 👍 ManageIQ/manageiq-providers-lenovo#54 is merged. |
|
I can't merge PRs in |
|
Great - thanks @juliancheal @blomquisg - can you merge please? |
bdunne
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendors values before could be any value, it caused a bug that inconsistent values for vendors was resulting in nil objects when use it as key for VENDOR_TYPES.
Now the vendor values are restricted to VENDOR_TYPES keys, avoiding a mismatch key.
Depends on: ManageIQ/manageiq-providers-lenovo#54