Ensure order is qualified by table name for rss feeds #15112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEFORE: ``` SELECT "vms"."id" [...] ORDER BY created_on DESC ``` This is problematic because if we later join another table to this scope and execute the query, if that table has a `created_on` field Postgres will complain and throw an error for the ambiguous statement. AFTER: ``` SELECT "vms"."id" [...] ORDER BY "vms"."created_on" DESC ``` Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451180
|
Checked commit imtayadeway@74ec0da with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add-label blocker |
simaishi
pushed a commit
that referenced
this pull request
May 17, 2017
Ensure order is qualified by table name for rss feeds (cherry picked from commit 0974ffc) https://bugzilla.redhat.com/show_bug.cgi?id=1451925
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE:
This is problematic because if we later join another table to this
scope and execute the query, if that table has a
created_onfieldPostgres will complain and throw an error for the ambiguous statement.
AFTER:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451180
Note: I tried to bisect but had great difficulty (because you need to check out all the git gems to be concurrent with the revision you're checking out in core), but since this seemed to be a good idea anyway (and works), I was satisfied.
@miq-bot add-label bug, core
@miq-bot assign @gtanzillo