Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory collection default for infra manager #15082

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

pkliczewski
Copy link
Contributor

Infra manager containing defaults for inventory collection. Needed for:

ManageIQ/manageiq-providers-ovirt#35

end

def clusters(extra_attributes = {})
attributes = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the parser you use uid_ems as manager ref, so in this case you should have here

:manager_ref => [:uid_ems]

def clusters(extra_attributes = {})
attributes = {
:model_class => ::EmsCluster,
:attributes_blacklist => [:ems_children]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing :association => :clusters

@pkliczewski pkliczewski force-pushed the master branch 2 times, most recently from b5759d7 to 372c9a3 Compare May 26, 2017 09:42
@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2017

Checked commit pkliczewski@3498e00 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@pkliczewski
Copy link
Contributor Author

This PR provides not finished default manager but it enables ManageIQ/manageiq-providers-ovirt#35 to run so it would be great to have it in as is and improve as we implement full refresh.

@pkliczewski pkliczewski changed the title [WIP] Inventory collection default for infra manager Inventory collection default for infra manager Jun 8, 2017
@pkliczewski
Copy link
Contributor Author

@borod108 @masayag @jhernand Please take a look

@miq-bot miq-bot removed the wip label Jun 8, 2017
@pkliczewski
Copy link
Contributor Author

@matobet please take a look

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@Ladas
Copy link
Contributor

Ladas commented Jun 8, 2017

@agrare should be ready to merge, there are few TODOs, but it's best to do them incrementally. @pkliczewski is focusing on having targeted refresh of the Vm done first.

@agrare agrare merged commit 09cba1c into ManageIQ:master Jun 8, 2017
@agrare agrare added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 8, 2017
@pkliczewski
Copy link
Contributor Author

Graph refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants