Start Apache if roles were changed and it is needed by the current roles #15078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that was introduced in da9523e when the Apache load balancer was made static. That removed the code that started Apache up after the role or worker count changed. https://bugzilla.redhat.com/show_bug.cgi?id=1449766
|
Checked commit gtanzillo@5a8f28e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Closing & re-opening to reschedule CI (there was a sporadic test failure in chargeback test we are hunting (also see #14923) |
carbonin
approved these changes
May 12, 2017
|
@gtanzillo I assume this should also be fine/yes? |
Yes, thanks @carbonin! |
@carbonin So you're saying it's a fine PR? I agree. |
simaishi
pushed a commit
that referenced
this pull request
May 18, 2017
Start Apache if roles were changed and it is needed by the current roles (cherry picked from commit d335171) https://bugzilla.redhat.com/show_bug.cgi?id=1452350
|
Euwe backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
Start Apache if roles were changed and it is needed by the current roles (cherry picked from commit d335171) https://bugzilla.redhat.com/show_bug.cgi?id=1458946
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that was introduced in da9523e when the Apache load balancer was made static.
That removed the code that started Apache up after the role or worker count changed.
https://bugzilla.redhat.com/show_bug.cgi?id=1449766
/cc @jrafanie