provision_request returns a miq_request object instead of a hash of error and miq_request #14987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1447793 If there are no errors we return the miq_request object else we raise an exception with the errors
|
@mkanoor Please address rubocop issues. |
|
@gmcculloug Please review |
gmcculloug
reviewed
May 4, 2017
app/models/service_template.rb
Outdated
| @@ -375,7 +375,9 @@ def self.create_from_options(options) | |||
| private_class_method :create_from_options | |||
|
|
|||
| def provision_request(user, options = nil, request_options = nil) | |||
| provision_workflow(user, options, request_options).submit_request | |||
| result = provision_workflow(user, options, request_options).submit_request | |||
| raise result[:errors].join(",") if result[:errors].any? | |||
There was a problem hiding this comment.
Minor, but please add a space after the comma to separate the data a little bit. .join(", ")
|
Checked commits mkanoor/manageiq@40fd359~...1da76a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
May 5, 2017
provision_request returns a miq_request object instead of a hash of error and miq_request (cherry picked from commit 2b2aff4) https://bugzilla.redhat.com/show_bug.cgi?id=1448506
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1447793
The provision request returns the miq_request object if there are no errors
else we raise an exception with the errors
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1447793
Create a provision request for a service template #13972
Steps for Testing/QA
Described in BZ