Added a check that URL is a type of HTTPS uri. #14965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliancheal
force-pushed
the
bz_satallite_https_error
branch
2 times, most recently
from
ae19c46 to
2770654
Compare
Relates to BZ 1405369
juliancheal
force-pushed
the
bz_satallite_https_error
branch
from
2770654 to
f20390a
Compare
juliancheal
changed the title
|
@miq-bot assign @blomquisg |
|
Checked commits juliancheal/manageiq@f20390a~...56b2238 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Any reason why Coverralls hasn't run? |
No idea |
|
Closing to see if we can rekick coveralls |
|
@blomquisg maybe it's just coveralls? Are we ok to merge? 🌵 |
|
Todo verde! 🍏 📗 💚 🥗 @blomquisg |
|
This looks good to go, but I'd like to see a screenshot of how the UI responds to that exception. |
|
Error message when URL is HTTP and not HTTPS
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to BZ 1405369
Forman UI allows non https uri, but then later fails with api and reprovisioning.