Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reports to be generated based on GuestApplication #14939

Merged
merged 1 commit into from
May 2, 2017
Merged

Allow reports to be generated based on GuestApplication #14939

merged 1 commit into from
May 2, 2017

Conversation

imtayadeway
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1412935

@miq-bot add-label reporting, core, enhancement
@miq-bot assign @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented Apr 28, 2017

Checked commit imtayadeway@cf3c6ca with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

gtanzillo
gtanzillo approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

@gtanzillo gtanzillo added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@gtanzillo gtanzillo merged commit e56661b into ManageIQ:master May 2, 2017
@simaishi
Copy link
Contributor

@gtanzillo @imtayadeway can this be fine/yes, euwe/yes and darga/yes (as per flags set on BZ)?

@gtanzillo
Copy link
Member

@simaishi Yes, I set the labels. Thanks.

simaishi pushed a commit that referenced this pull request May 24, 2017
@gtanzillo @simaishi
Merge pull request #14939 from imtayadeway/reports/add-guest-applicat…
b5e0a72 
…ions

Allow reports to be generated based on GuestApplication
(cherry picked from commit e56661b)

https://bugzilla.redhat.com/show_bug.cgi?id=1455302
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit b5e0a72a3199ebf52b172d486c53823aef2193fc
Author: Gregg Tanzillo <[email protected]>
Date:   Tue May 2 11:56:17 2017 -0400

    Merge pull request #14939 from imtayadeway/reports/add-guest-applications
    
    Allow reports to be generated based on GuestApplication
    (cherry picked from commit e56661b759547b989e32379adc016d3151e9422a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1455302

simaishi pushed a commit that referenced this pull request Jun 2, 2017
@gtanzillo @simaishi
Merge pull request #14939 from imtayadeway/reports/add-guest-applicat…
a650210 
…ions

Allow reports to be generated based on GuestApplication
(cherry picked from commit e56661b)

https://bugzilla.redhat.com/show_bug.cgi?id=1458365
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit a6502109aa590b933a1e49c6fe01cc574c040ab8
Author: Gregg Tanzillo <[email protected]>
Date:   Tue May 2 11:56:17 2017 -0400

    Merge pull request #14939 from imtayadeway/reports/add-guest-applications
    
    Allow reports to be generated based on GuestApplication
    (cherry picked from commit e56661b759547b989e32379adc016d3151e9422a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
core/reporting core enhancement euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtayadeway @miq-bot @simaishi @gtanzillo