Support array of objects for custom button support

[mkanoor]

https://www.pivotaltracker.com/n/projects/1613907/stories/140944305

These are changes in the Automate side to handle being passed in an array of objects.
The objects are not loaded by the Automate Engine, they are loaded by the Automate Method based on the passed in target_object_type and target_object_ids.

Links

• https://www.pivotaltracker.com/n/projects/1613907/stories/140944305

• Custom Buttons: Submit multiple objects to automate at once #14877

• Sample Automate Method that gets passed in array of objects -

$evm.log(:info, "Object Type: #{$evm.root['target_object_type']}")
$evm.log(:info, "Object IDS: #{$evm.root['target_object_ids']}")
klass = $evm.vmdb($evm.root['target_object_type'])
$evm.root['target_object_ids'].each do |id|
  obj = klass.find(id)
  $evm.log(:info, "Object name is #{obj.name}")
end

[tinaafitz]

@mkanoor Looks good.

[mkanoor]

@gmcculloug
Since the caller could be passing in vms which could be in different zones, what should be the value of the zone when putting into the queue. (nil or default).
I have implemented it with the value being nil
https://github.com/ManageIQ/manageiq/blob/master/app/models/custom_button.rb#L76

[gmcculloug]

Looks like override_attrs is a required hash field so this could be:

override_attrs.merge!(:array_object_type => target.first.class.base_class.name,
                     'Array::object_ids' => object_ids)

Also, what do you think about making the naming here a little more unique/consistent? target_object_type and target_object_ids

[mkanoor]

@gmcculloug the override_attrs can also be nil so we have to initialize it before we do the merge

[gmcculloug]

@Fryguy Looking for your thoughts on this one. The idea is to avoid overloading the automation process when passed an array of objects to load by passing the class/IDs into the method and letting the automate method process them as needed.

The current usage is from custom buttons on a list-view so this is only handling a single object type.

[miq-bot]

Checked commits mkanoor/manageiq@1c94dc0~...9a60fbd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[martinpovolny]

ping @Fryguy?

Can you delegate someone if you don't have time for this one, please?

I'd like to use this from the UI. Thx!

[chessbyte]

@Fryguy bump