Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync up dropdown list in My Settings => Visual Tab => Start Up #14914

Merged

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Apr 26, 2017

This fix requires MiqShortcut.seed to refresh startup settings and db table

Syncs up drop down list entries for Start Up pages to match those in Compute / Clouds menus in recent UI upgrades.

https://bugzilla.redhat.com/show_bug.cgi?id=1331399

Compute / Cloud menus screen shot:
compute clouds ui menus

My Settings / Visual Tab / Start Up pages dropdown list prior to code fix:
visual tab start page show at login part 1 before code fix
visual tab start page show at login part 2 before code fix

My Settings / Visual Tab / Start Up pages dropdown list after code fix:
visual tab start page show at login dropdown after code fix

@GregP
Copy link
Contributor Author

GregP commented Apr 26, 2017

@h-kataria Please review. Will need to make other code upgrades to match current Compute / Infrastructure and Containers menus.

@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

Checked commit GregP@9491f04 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@GregP
Copy link
Contributor Author

GregP commented Apr 27, 2017

@h-kataria Please review.

@h-kataria
Copy link
Contributor

LGTM

@GregP GregP closed this Apr 27, 2017
@GregP GregP reopened this Apr 27, 2017
@chessbyte chessbyte self-assigned this Apr 27, 2017
@chessbyte chessbyte merged commit 07814e4 into ManageIQ:master Apr 27, 2017
@chessbyte chessbyte added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@kbrock kbrock mentioned this pull request Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants