-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the db application_name after the server row is created #14904
Merged
gtanzillo
merged 1 commit into
ManageIQ:master
from
jrafanie:set_db_application_name_after_server_row_created
Apr 26, 2017
Merged
Set the db application_name after the server row is created #14904
gtanzillo
merged 1 commit into
ManageIQ:master
from
jrafanie:set_db_application_name_after_server_row_created
Apr 26, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in ManageIQ#13856 when you run rake evm:start on a database without a server row for the current server: undefined method database_application_name for nil:NilClass.
Checked commit jrafanie@a77023f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gtanzillo
approved these changes
Apr 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jrafanie
pushed a commit
to jrafanie/manageiq
that referenced
this pull request
Apr 26, 2017
…me_after_server_row_created Set the db application_name after the server row is created
jrafanie
pushed a commit
to jrafanie/manageiq
that referenced
this pull request
Apr 26, 2017
…me_after_server_row_created Set the db application_name after the server row is created
This was referenced Apr 26, 2017
simaishi
pushed a commit
that referenced
this pull request
Jun 2, 2017
…_server_row_created Set the db application_name after the server row is created (cherry picked from commit 90197b1) https://bugzilla.redhat.com/show_bug.cgi?id=1458339
Fine backport details:
|
Changing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1445928
Fixes a bug in #13856 when you run rake evm:start on a database without
a server row for the current server: undefined method
database_application_name for nil:NilClass.