Join RBAC check for MiqUserRole, User and MiqGroup to one if branch #14901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
join_rbac_for_role_user_and_group_to_one_if_branch
branch
from
06b3f17 to
e9b79de
Compare
lpichler
changed the title
|
Checked commits lpichler/manageiq@998f45c~...e9b79de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
isimluk
reviewed
May 2, 2017
lib/rbac/filterer.rb
Outdated
| elsif klass == MiqGroup && miq_group.try!(:self_service?) | ||
| # Self Service users searching for groups only see their group | ||
| scope.where(:id => miq_group.id) | ||
| elsif [User, MiqGroup].include?(klass) && (miq_group || user).try!(:self_service?) |
There was a problem hiding this comment.
Interestingly, we can do this. Since the miq_group getting here should be always equal to user.current_group (if both supplied). And the self_service? method get's routed to the current_group.
Net result is the same. Even though, I keep scratching my chin at this. :)
|
Hehe. Was gonna merge this also :-D and the button was gone! |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
May 2, 2017
…roup_to_one_if_branch Join RBAC check for MiqUserRole, User and MiqGroup to one if branch (cherry picked from commit b8adc25) https://bugzilla.redhat.com/show_bug.cgi?id=1447372
|
Fine backport details: |
|
thanks @lpichler - sorry, late to the party |
|
@miq-bot add_label bug |
|
@miq-bot add_label euwe/yes |
simaishi
pushed a commit
that referenced
this pull request
Jun 20, 2017
…roup_to_one_if_branch Join RBAC check for MiqUserRole, User and MiqGroup to one if branch (cherry picked from commit b8adc25) https://bugzilla.redhat.com/show_bug.cgi?id=1460979
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBAC check for MiqUserRole, User, MiqGroup models - these checks are related so
I think they should be together. This could be helpful to implement the other condition for MiqGroup and Group described in #14903
Depends on(reason of WIP):
#14898
Continue in #14903 (blocker)
Starting in commit Join User and Group rbac check to one if branch
@miq-bot add_label wip, fine/yes, refactoring
@miq-bot assign @gtanzillo
cc @kbrock