Sleep some more time in ansible targeted refresh #14899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sleep here is also needed because tower needs some time to actually propagate it's updates if we would return immediately it _could_ be that the we get the old playbooks the whole sleep business is a workaround anyway until we get proper polling via ManageIQ#14405
|
Checked commit durandom@85090c9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
reviewed
Apr 26, 2017
| # if we would return immediately it _could_ be that the we get the old playbooks | ||
| # the whole sleep business is a workaround anyway until we get proper polling via the PR mentioned above | ||
| sleep REFRESH_ON_TOWER_SLEEP | ||
| break if project_update.finished.present? |
There was a problem hiding this comment.
Is the problem that even though the API reports something in project_update.finished the update isn't actually finished?
There was a problem hiding this comment.
my guess is, the update has finished (update is a job in tower), but it takes some ms to propagate those changes to the playbook tables...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sleep here is also needed because tower needs some time
to actually propagate it's updates
if we would return immediately it could be that the we get
the old playbooks
So we always sleep 1 second after the update has finished
the whole sleep business is a workaround anyway until we get
proper polling via #14405
adresses https://bugzilla.redhat.com/show_bug.cgi?id=1442170
@miq-bot add_label bug, providers/ansible_tower