Use credential callback to set credentials #14889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmcculloug @Fryguy @eclarizio |
|
@gmcculloug bump |
eclarizio
reviewed
Jun 2, 2017
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
|
This pull request is not mergeable. Please rebase and repush. |
mkanoor
force-pushed
the
bad_credentials
branch
from
953fd0f to
115f021
Compare
|
Checked commits mkanoor/manageiq@115f021~...4928e89 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gmcculloug Please review |
simaishi
pushed a commit
that referenced
this pull request
Apr 17, 2018
Use credential callback to set credentials (cherry picked from commit 2dd64f8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568602 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568604
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 17, 2018
Use credential callback to set credentials (cherry picked from commit 2dd64f8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568603 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568605
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Use credential callback to set credentials (cherry picked from commit 2dd64f8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568603 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1443106
https://bugzilla.redhat.com/show_bug.cgi?id=1552274
Rugged works using callbacks for credentials. The callback can be either a credential object or a callback that returns a credential object. If the credentials are invalid the callback is called again, it is designed to be used in a UI, where the UI can prompt the user for entering the updated userid/password. If the user doesn't want to enter the userid/password they can cancel it.
Since the callback is being called repeatedly it gives the feeling that the UI is stuck or the rake import command is stuck.
We record that the credential has been set once in the callback and if called again it raises an exception which rugged sends back to the caller.
Links