Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method to InfraManager to retrieve Hosts without EmsCluster #14884

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Add a method to InfraManager to retrieve Hosts without EmsCluster #14884

merged 1 commit into from
Apr 25, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 25, 2017 •
edited
Loading

If an infra provider has clusterless hosts, they aren't displayed in the topology view. This method allows the topology service to easily map these hosts into the topology hash.
UI part: ManageIQ/manageiq-ui-classic#1156

https://bugzilla.redhat.com/show_bug.cgi?id=1440263

@skateman skateman mentioned this pull request Apr 25, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

Checked commit skateman@d54d057 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@gtanzillo gtanzillo added this to the Sprint 60 Ending May 8, 2017 milestone Apr 25, 2017
gtanzillo
gtanzillo approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@gtanzillo gtanzillo merged commit a90ca1e into ManageIQ:master Apr 25, 2017
@skateman skateman deleted the clusterless-hosts branch April 25, 2017 20:15
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

@skateman @gtanzillo ManageIQ/manageiq-ui-classic#1156 is fine/yes and depends on this PR. Can this be fine/yes?

@skateman
Copy link
Member Author

skateman commented Jun 5, 2017

@simaishi you're right!
@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Jun 5, 2017
@gtanzillo @simaishi
Merge pull request #14884 from skateman/clusterless-hosts
9e05d31 
Add a method to InfraManager to retrieve Hosts without EmsCluster
(cherry picked from commit a90ca1e)

https://bugzilla.redhat.com/show_bug.cgi?id=1458930
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit 9e05d310e6aeb8d271c782840ad251493ca17c6d
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Apr 25 16:13:35 2017 -0400

    Merge pull request #14884 from skateman/clusterless-hosts
    
    Add a method to InfraManager to retrieve Hosts without EmsCluster
    (cherry picked from commit a90ca1e2f2ef385bb3677a5cd7a760809cd09b1e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug fine/backported providers/infrastructure providers/topology
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skateman @miq-bot @simaishi @gtanzillo