Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. test cleanup #14869

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Misc. test cleanup #14869

merged 1 commit into from
Apr 26, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Apr 24, 2017 •
edited
Loading

Followup to #14834
No need to create a server, guid, zone
The name of the method being tested should be displayed
Expect :has_attribute?, it's important

@bdunne bdunne requested a review from lgalis April 24, 2017 22:02
isimluk
isimluk suggested changes Apr 25, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing the allow statement you are testing different code path.

Previously this went with the if branch, now it goes with the else branch (see aggregate_all_vm_memory_on_disk).

Was it intentional?

@bdunne
Misc. test cleanup
15bc9e9 
No need to create a server, guid, zone
The name of the method being tested should be displayed
Expect :has_attribute?, it's important
@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

Checked commit bdunne@15bc9e9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@bdunne
Copy link
Member Author

bdunne commented Apr 25, 2017

Thanks @isimluk I thought I had verified that. Since it feels important, I added it back as an expect.

isimluk
isimluk approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks!

@isimluk isimluk added this to the Sprint 60 Ending May 8, 2017 milestone Apr 26, 2017
@isimluk isimluk merged commit 2cd30b6 into ManageIQ:master Apr 26, 2017
@bdunne bdunne deleted the cleanup_test branch April 26, 2017 13:38
simaishi pushed a commit that referenced this pull request Jun 2, 2017
@isimluk @simaishi
Merge pull request #14869 from bdunne/cleanup_test
1d1ead8 
Misc. test cleanup
(cherry picked from commit 2cd30b6)
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit 1d1ead8dca51419410563d9d577f947be863151f
Author: Šimon Lukašík <[email protected]>
Date:   Wed Apr 26 12:05:58 2017 +0200

    Merge pull request #14869 from bdunne/cleanup_test
    
    Misc. test cleanup
    (cherry picked from commit 2cd30b6aa9180b164d7385ab1ef0deb9f9851eae)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

@lgalis lgalis Awaiting requested review from lgalis

Assignees

@isimluk isimluk

Labels
fine/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @simaishi @isimluk