Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore public/packs - webpacker assets output #14839

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Gitignore public/packs - webpacker assets output #14839

merged 1 commit into from
Apr 21, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 21, 2017

webpacker puts its output in public/packs (and then sprockets picks that up from there and puts it in the regular place).

Gitignoring that :).

(This looks like the only change made by rake webpacker:install that should live in the main repo.)

@miq-bot add_label developer, ui, fine/no

[webpacker](https://github.com/rails/webpacker) puts its output in public/packs (and then sprockets picks that up from there and puts it in the regular place).

Gitignoring that :).

(This looks like the only change made by `rake webpacker:install` that should live in the main repo.)
@miq-bot
Copy link
Member

miq-bot commented Apr 21, 2017

Checked commit https://github.com/himdel/manageiq/commit/7537fc3bb8c85abdd968cb988b41af78612dd302 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@chessbyte chessbyte self-assigned this Apr 21, 2017
@chessbyte chessbyte merged commit 503cabf into ManageIQ:master Apr 21, 2017
@chessbyte chessbyte added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 21, 2017
@himdel himdel deleted the webpacker-ignore branch April 24, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants